refactor: create go.mod for x/params #17776
Conversation
github-prbot
requested review from
a team,
facundomedica and
julienrbrt
and removed request for
a team
There was a problem hiding this comment.
Why only the keeper? And we may want to do this before (#17360), so that the SDK does not import params anymore (which will give cyclic dep if not).
|
@julienrbrt I was doing one module at a time as advised in the original issue. |
I see, but it should be the whole x/params to be its own go.mod, not only its keeper. |
|
Gotcha! Indeed I had started with x/params but saw that it was deprecated and the notice in the README.md said each module housed its own params, let me make that update. Thanks @julienrbrt! |
odeke-em
force-pushed
the
go.mod-spin-out-x-params-keeper
branch
from
7c2443d to
937c7a3
Compare
odeke-em
changed the title
odeke-em
force-pushed
the
go.mod-spin-out-x-params-keeper
branch
from
937c7a3 to
e4006c3
Compare
github-actions
bot
added
C:x/staking
C:CLI
C:x/gov
C:x/slashing
C:x/distribution
github-actions
bot
removed
C:x/slashing
C:x/mint
C:x/bank
C:x/auth
C:x/authz
C:x/group
labels
odeke-em
force-pushed
the
go.mod-spin-out-x-params-keeper
branch
5 times, most recently
from
08f0b48 to
3464185
Compare
go.work.example
Outdated
| @@ -25,5 +25,6 @@ use ( | |||
| ./x/circuit | |||
| ./x/feegrant | |||
| ./x/evidence | |||
| ./x/params/keeper | |||
odeke-em
force-pushed
the
go.mod-spin-out-x-params-keeper
branch
from
3464185 to
b3c1e10
Compare
go.mod
Outdated
| @@ -1,6 +1,4 @@ | |||
| go 1.21 | |||
|
|
|||
| toolchain go1.21.0 | |||
There was a problem hiding this comment.
My Go's go mod tidy did that, let me manually revert. Sorry about that.
There was a problem hiding this comment.
oh all good, this forces the usage of go 1.12 from my knowledge. what settings do you have on your go mod?
| @@ -39,7 +39,7 @@ import ( | |||
| banktypes "github.com/cosmos/cosmos-sdk/x/bank/types" | |||
| consensusparamtypes "github.com/cosmos/cosmos-sdk/x/consensus/types" | |||
| minttypes "github.com/cosmos/cosmos-sdk/x/mint/types" | |||
| paramtypes "github.com/cosmos/cosmos-sdk/x/params/types" | |||
There was a problem hiding this comment.
i think we should be able to drop this dep?
There was a problem hiding this comment.
It's under tests/integration, so it's fine. We still test params for x/tx amino support
x/evidence/go.mod
Outdated
| @@ -13,14 +13,14 @@ require ( | |||
| cosmossdk.io/store v1.0.0-rc.0 | |||
| github.com/cometbft/cometbft v0.38.0 | |||
| github.com/cosmos/cosmos-proto v1.0.0-beta.3 | |||
| github.com/cosmos/cosmos-sdk v0.46.0-beta2.0.20230713190037-6a0ab4fd167f | |||
| github.com/cosmos/cosmos-sdk v0.47.5 | |||
There was a problem hiding this comment.
we should push this to the latest version of the releases?
cc @julienrbrt
There was a problem hiding this comment.
We should either use a pseudo version from main (v0.46.0-beta2.xxxx) or a fake version (#17776 (comment)) and replace the SDK.
Definitely not a released version on main.
Makes x/params a standalone Go module accessible via vanity URL path cosmossdk.io/x/params Updates #11899
odeke-em
force-pushed
the
go.mod-spin-out-x-params-keeper
branch
from
b3c1e10 to
30b6984
Compare
|
[Cosmos SDK - x/params] Kudos, SonarCloud Quality Gate passed!
|
|
Oh wow, thank you very much @julienrbrt for getting this over the line! Thank you very much for the reviews birth of you @tac0turtle and @julienrbrt |
Makes x/params/keeper a standalone Go module accessible via vanity URL path cosmossdk.io/x/params
Updates #11899